Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): add description for Lit #12440

Closed
wants to merge 1 commit into from

Conversation

fi3ework
Copy link
Member

Description

Partially avoid the possibility of #12431.

Untitled.mp4

Additional context

Should we use Lit to create applications as others in the next major version of create-vite? 🤔


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

I think we should move the Lit template to be an app instead of using library mode. This has confused others in the past: #5620. If we want an example of a library, we can use create-vite-extra, no @bluwy?
We could release it in a minor of create-vite, I don't think it is an issue. I don't think it counts as a breaking change for create-vite.

@bluwy
Copy link
Member

bluwy commented Mar 16, 2023

Making it an app by default sounds good to me too. It was added by Evan at 830f3d3, maybe we can check with him to confirm the intention. Happy to move the library version to create-vite-extra too.

@patak-dev
Copy link
Member

Thanks for pushing to improve this @fi3ework, let's close this one in favour of making it an app like the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants