-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): add solidjs templates (#12218) #12241
Conversation
|
The failing test must be because this is a template and it uses a dependencies that we don't need in vite itself, I don't know if we should be looking for it in some way. Can someone check it out please. 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs a bit of changes to match currently the other templates. To fix the lint, you need to follow the template naming convention of template-*
. For solid, it should be template-solid
and template-solid-ts
.
The comments below are for the JS template, but they should also apply for the TS template. You can also follow https://github.com/bluwy/create-vite-extra/tree/master/template-ssr-solid and https://github.com/bluwy/create-vite-extra/tree/master/template-ssr-solid-ts to see how the base code is setup.
Thank you for the review 👍🏼👍🏼 I'll add this changes tonight hopefully. |
This should fix the tests
React => Solid
This should do for the changes you requested. For the failing test, do you have any thoughts about the reason and any suggestions to solve it? |
Any updates for the issue? Can someone recommend anything to try to solve this check? |
Try rebasing onto the latest commits in I also think you might want to stick to the official templates https://github.com/solidjs/templates. They power https://solid.new. |
I just did now, waiting to see if there are any changes, but for the changes to the But thanks for helping. |
I made some additional changes to add the links to the website, also the build seems to be passing on my branch. #12726 |
I just had to rebase my branch... Didn't think of that one heh... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes required:
- let's remove the spinning logo. It works well for React but less for solid
- make tsc works on the TS template. It requires adding
vite-env.d.ts
and fixing the JSX typing issue.
Any updates? |
I need to test that there is no tsc issues now (didn't see changes related to the jsx target issue) |
I'm not sure how to fix the typing issues with jsx yet, I'll research it |
@AbdelrahmanDwedar https://github.com/solidjs/templates/blob/master/ts-vitest/tsconfig.json, I bet you need to add
|
I added it and it's still giving me errors in vscode |
This solves the issue of the code not working
Yeah stackblitz is missing the latest update of VSCode that fix this. Let's wait a few days and test again |
The tests passes!! Can someone now review again and see if there's any out-dated things we need to fix or anything? |
Is everything going fine? This PR was approved about two weeks ago and no updates then.. |
This comment was marked as spam.
This comment was marked as spam.
Co-authored-by: Arnaud Barré <[email protected]> Co-authored-by: bluwy <[email protected]>
Description
Adding the templates for solid.js to the creating templates.
Additional context
This pull request closes: #12218
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).