Closed
Conversation
|
@maccuaa hello, can you resolve conflicts and this to maybe merge faster ? 🤔 Thank you for your work 👌🏻 |
9049c92 to
0c6b3c7
Compare
Contributor
Author
Done! |
holtolee
approved these changes
May 9, 2023
73k05
approved these changes
Jul 13, 2023
add support for including a nonce placeholder in html script and link tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Currently, if you include a
nonceattribute onscriptorstyletags in your html file, Vite will strip it out. See discussion #5218This PR adds a new build option for specifying a nonce placeholder. If specified,
scriptandlinktags will include the nonce placeholder in the generated HTML. This allows applications to support nonces in their Content Security Policy.Fixes #9719
The downside of this PR is it includes yet another option to the build config which goes against the Think Before Adding Yet Another Option
section of the PR guide.
Ideally, this could be achieved by just not stripping out the nonce tag building your app.
Related PRs
styletags in Dev mode)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).