Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pnpm devDependency #11758

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

dominikg
Copy link
Contributor

Description

found that during debugging an issue in vite-ecosystem-ci and havn't seen any usage of it.
Having it as a local devDependency causes it to be used over global pnpm after the global was used for the initial install.
This can cause mismatches.

If we want to enforce a certain pnpm version, using engines.pnpm alongside the already set packageManager field would be a better option imho.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

sapphi-red commented Jan 20, 2023

My understanding is that this exists to lock the version of pnpm used here.

command = "npx pnpm i --store=node_modules/.pnpm-store --frozen-lockfile && npm run ci-docs"

So I think we can remove this when we can revert #11477. (#11759)

@dominikg
Copy link
Contributor Author

dominikg commented Jan 20, 2023

pinning pnpm that way comes with the drawbacks mentioned above and seeing that the current value is ^7.25.0 which isn't really pinning, i think it would be better to use npx pnpm@version ... in that script if we have that need again in the future

@sapphi-red
Copy link
Member

Ah, that makes sense.

@sapphi-red sapphi-red merged commit b35fe88 into vitejs:main Jan 20, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
sxzz added a commit to vitejs/vite-plugin-vue that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants