Skip to content

fix: fix the error message in the toOutputFilePathWithoutRuntime function #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sapphi-red merged 1 commit into from
Dec 14, 2022
Merged

fix: fix the error message in the toOutputFilePathWithoutRuntime function #11367

sapphi-red merged 1 commit into from
Dec 14, 2022

Conversation

@7nohe
Copy link
Contributor

@7nohe 7nohe commented Dec 14, 2022

Description

Fix the error message in the toOutputFilePathWithoutRuntime function.

Additional context

The semicolon was in the wrong place.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 14, 2022
sapphi-red
sapphi-red approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit 8820f75 into vitejs:main Dec 14, 2022
@7nohe 7nohe deleted the fix/unsupported-runtime-error-message branch December 19, 2022 02:27
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@7nohe @futurGH
fix: fix the error message in the toOutputFilePathWithoutRuntime fu…
de87450 
…nction (vitejs#11367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@7nohe @sapphi-red