chore: rename test packages #11172
Merged
chore: rename test packages #11172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Dec 4, 2022
Comment on lines
-287
to
-290
| test('@import dependency w/ stylus entry', async () => { | ||
| expect(await getColor('.css-dep-stylus')).toBe('red') | ||
| }) | ||
|
|
There was a problem hiding this comment.
I removed this test because this test was not testing the stylus entry and this feature wasn't working in the first place.
This test was passing because @import 'css-dep' was resolved by relative path.
refs #2860
|
Amazing work! |
This was referenced Dec 4, 2022
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames internal packages for tests to have a
@vitejs/test-prefix. This can avoid possible issues in future. For example, previously we had a false-positive security alert from dependabot.I guess this PR will make other PRs in a conflict state.
But because #11167 was merged recently, I think it's a good opportunity to merge this change.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).