Skip to content

Conversation

@benmccann
Copy link
Collaborator

Description

Don't throw an exception on malformed URLs

Additional context

A follow-up fix to #10475

SvelteKit CI is currently failing against Vite 4, but this fixes it


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Nov 13, 2022
@patak-dev patak-dev enabled auto-merge (squash) November 13, 2022 08:38
@patak-dev patak-dev merged commit feb9b10 into vitejs:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants