Conversation
bluwy
added
the
p3-downstream-blocker
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
Author
|
Hmm looks like this fixed |
patak-cat
approved these changes
Oct 21, 2022
Member
patak-cat
left a comment
patak-cat
left a comment
There was a problem hiding this comment.
The svelte fail is unrelated to this change, no? I think we should merge this one and attempt to change it in Vite 4 if it is breaking vite-plugin-ssr
Member
Author
|
Yeah I don't think the Svelte fail is caused by this given it failed in both cases. So something else likely caused the failure. Merging this 👍 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in discord (here and here). Revert the specific change from #10371.
Additional context
cc @benmccann
What is the purpose of this pull request?