Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): support create-vite-extra #10214

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 23, 2022

Description

Add create-vite-extra under new Others option in framework selection:

✔ Project name: … vite-project
✔ Select a framework: › Others
? Select a variant: › - Use arrow-keys. Return to submit.
❯   create-vite-extra ↗

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 23, 2022
@patak-dev
Copy link
Member

I think this is a good idea, allowing folks to reach out for a curated list of templates without adding extra burden on the Vite Core repo. Let's discuss it in today's meeting.

Do you know why Others doesn't get underlined when selected? Not a big deal, it was just a bit surprising when I tested it.

@bluwy
Copy link
Member Author

bluwy commented Sep 23, 2022

Seems like using the reset color removes the underline, all perhaps we can choose a different color.

patak-dev
patak-dev previously approved these changes Sep 23, 2022
@bluwy
Copy link
Member Author

bluwy commented Sep 25, 2022

From last meeting's discussion, I've moved create-vite-extra under the new Others option in the framework selection step. I also added for options that open a new CLI.

@patak-dev patak-dev merged commit 8116cbd into main Oct 14, 2022
@patak-dev patak-dev deleted the create-vite-extra branch October 14, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants