Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): trigger css hmr on custom template languages #6987

Merged
merged 3 commits into from
May 13, 2022

Conversation

sibbng
Copy link
Contributor

@sibbng sibbng commented Feb 18, 2022

Description

Fix #4588

These changes simply carry mainModule's CSS dependencies into template HMR's affected modules list.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@mariohamann
Copy link

Any change to get that into Vite soon, @Niputi ? :)

@Niputi Niputi added the p2-to-be-discussed Enhancement under consideration (priority) label Apr 25, 2022
@masterkain
Copy link

I'd love to see this fixed for this long standing issue with vite / vue / pug / tailwind 👍

@patak-dev patak-dev added p3-minor-bug An edge case that only affects very specific usage (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) labels May 12, 2022
@antfu antfu merged commit 2289d04 into vitejs:main May 13, 2022
@sibbng sibbng deleted the fix/pug-style-updates branch May 13, 2022 07:43
@carrrramba
Copy link

i've encountered the same problem with vite vanilla js + tailwind jit + handlebars instead of pug. Demo here: https://stackblitz.com/edit/vitejs-vite-acozht?file=index.html

@patak-dev
Copy link
Member

@carrrramba please create a new bug report linking to this PR so we can properly track these issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using pug with vite+tailwindcss in JIT mode causes HMR to not detect changes in new css compiled classes
10 participants