Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate tailwind + pug test from Vite repo #224

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

sapphi-red
Copy link
Member

Description

Migrated tailwind + pug test (vitejs/vite#6987) from Vite main repo.
I tested that this test fails if this part is removed.

} else if (mainModule && !affectedModules.has(mainModule)) {
const styleImporters = [...mainModule.importers].filter((m) =>
isCSSRequest(m.url),
)
styleImporters.forEach((m) => affectedModules.add(m))
}

refs vitejs/vite#11175

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@haoqunjiang haoqunjiang merged commit 729181c into main Aug 14, 2023
7 checks passed
@haoqunjiang haoqunjiang deleted the test/migrate-tailwind-pug-test branch August 14, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants