HMR is not completely disabled

[MarryDream]

Describe the bug

For some specific reason, I had to start the project using Vite in the production environment. At this point, I set config.server.hmr to false in an attempt to avoid unnecessary overhead in the production environment. However, I found that when set to false, the page still creates websocket requests and sends ping messages periodically. However, when the server firewall does not open the default port 24678, the Websocket fails to connect, which triggers a shutdown event and causes the page to auto-refresh over and over again. The Websocket connection seemed useless when config.server.hmr was set to false, so I made some changes to avoid creating a Websocket connection in this case.

Reproduction

https://github.com/MarryDream/vite-hmr-demo

Steps to reproduce

npm i
npm start

Please deploy to a production server for testing，allow port 11451 on the firewall and access http://ip:11451. But do not allow port 24678

System Info

System:
    OS: Linux 3.10 CentOS Linux 7 (Core)
    CPU: (2) x64 Intel(R) Xeon(R) Gold 6133 CPU @ 2.50GHz
    Memory: 2.83 GB / 7.64 GB
    Container: Yes
    Shell: 4.2.46 - /bin/bash
  Binaries:
    Node: 16.14.0 - /opt/node/v16.14.0/bin/node
    npm: 8.3.1 - /opt/node/v16.14.0/bin/npm
    pnpm: 8.6.10 - /opt/node/v16.14.0/bin/pnpm
  npmPackages:
    @vitejs/plugin-vue: ^4.2.3 => 4.2.3 
    vite: ^4.4.7 => 4.4.7

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

The websocket is used for more than just HMR, including showing error overlay from server and trigger full page reloads from plugins.
#6315 (comment)

So Vite shouldn't disable websocket even if config.server.hmr: false is set.

Maybe you can transform the @vite/client by the transform hook?

[MarryDream]

The websocket is used for more than just HMR, including showing error overlay from server and trigger full page reloads from plugins.
#6315 (comment)

So Vite shouldn't disable websocket even if config.server.hmr: false is set.

Maybe you can transform the @vite/client by the transform hook?

I'm very sorry, I didn't notice that this issue had already been mentioned, after looking at #9007 ，I tried to work around it by customizing hmr.server, which seems to be working so far.

[sapphi-red]

I'll close this issue then 👍