Missing gzip information for HTML files in build logs output

[meduzen]

Describe the bug

On top of the uncompressed file size, Vite 3 displayed the gzip size for HTML, CSS, JS and (if I’m correct) SVG files.

The gzip size for HTML files is currently missing from Vite 4 build output. I think it should be included, as it’s a useful information.

Reproduction

https://github.com/meduzen/canwe/tree/vite-4

Steps to reproduce

Run npm install and npm run build.

System Info

System:
    OS: macOS 12.6.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Shell: 5.9 - /usr/local/bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  npmPackages:
    vite: ^4 => 4.0.0

Used Package Manager

npm

Logs

Click to expand!

❯ npm run build --debug

> build
> vite build --mode=production --debug

  vite:config bundled config file loaded in 181.03ms +0ms
  vite:esbuild init tsconfck (root: /my-hidden-locale-path/some-project) +0ms
  vite:esbuild init tsconfck (root: /my-hidden-locale-path/some-project) +1ms
  vite:esbuild init tsconfck (root: /my-hidden-locale-path/some-project) +1ms
  vite:esbuild init tsconfck (root: /my-hidden-locale-path/some-project) +0ms
  vite:esbuild init tsconfck end +6ms
  vite:esbuild init tsconfck end +0ms
  vite:esbuild init tsconfck end +0ms
  vite:esbuild init tsconfck end +0ms
  vite:config using resolved config: {
  vite:config   root: '/my-hidden-locale-path/some-project/src',
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: '../public',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: false,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: { input: [Object] },
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: true,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     envDir: './',
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true }
  vite:config   },
vite:config   resolve: {
  vite:config     mainFields: [ 'module', 'jsnext:main', 'jsnext' ],
  vite:config     browserField: true,
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object], [Object] ]
  vite:config   },
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     open: false,
  vite:config     middlewareMode: false,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:html',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:force-systemjs-wrap-complete',
  vite:config     'vite:watch-package-data',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:minify-html',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
vite:config   mode: 'production',
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     esbuildOptions: { preserveSymlinks: false }
  vite:config   },
  vite:config   configFile: '/my-hidden-locale-path/some-project/vite.config.js',
  vite:config   configFileDependencies: [ '/my-hidden-locale-path/some-project/vite.config.js' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: 'production',
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     build: {}
  vite:config   },
  vite:config   base: '/',
  vite:config   rawBase: '/',
  vite:config   publicDir: '/my-hidden-locale-path/some-project/src/public',
  vite:config   cacheDir: '/my-hidden-locale-path/some-project/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   ssr: {
  vite:config     format: 'esm',
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: true,
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: false,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
 vite:config   packageCache: Map(0) { set: [Function (anonymous)] },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       'vite:build-metadata',
  vite:config       'vite:pre-alias',
  vite:config       'alias',
  vite:config       'vite:modulepreload-polyfill',
  vite:config       'vite:resolve',
  vite:config       'vite:html-inline-proxy',
  vite:config       'vite:css',
  vite:config       'vite:esbuild',
  vite:config       'vite:json',
  vite:config       'vite:wasm-helper',
  vite:config       'vite:worker',
  vite:config       'vite:asset',
  vite:config       'vite:wasm-fallback',
  vite:config       'vite:define',
  vite:config       'vite:css-post',
  vite:config       'vite:build-html',
  vite:config       'vite:worker-import-meta-url',
  vite:config       'vite:asset-import-meta-url',
  vite:config       'vite:force-systemjs-wrap-complete',
  vite:config       'vite:watch-package-data',
  vite:config       'commonjs',
  vite:config       'vite:data-uri',
  vite:config       'vite:dynamic-import-vars',
  vite:config       'vite:import-glob',
  vite:config       'vite:build-import-analysis',
  vite:config       'vite:esbuild-transpile',
  vite:config       'vite:terser',
  vite:config       'vite:load-fallback'
  vite:config     ],
  vite:config     rollupOptions: {},
  vite:config     getSortedPlugins: [Function: getSortedPlugins],
  vite:config     getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config   },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +15ms
vite v4.0.0 building for production...                                                                                                                                                                                     18:38:53
transforming (1) index.html  vite:resolve 5.11ms easings.scss -> /my-hidden-locale-path/some-project/node_modules/easings.scss/src/index.scss +0ms
  vite:resolve 4.78ms hsl.scss -> /my-hidden-locale-path/some-project/node_modules/hsl.scss/src/functions/hsl.scss +146ms
  vite:resolve 1.37ms v.scss -> /my-hidden-locale-path/some-project/node_modules/v.scss/src/functions/v.scss +4ms
  vite:resolve 2.77ms double-dash.scss -> /my-hidden-locale-path/some-project/node_modules/double-dash.scss/src/double-dash.scss +27ms
✓ 2 modules transformed.                                                                                                                                                                                                   18:38:54
../public/index.html                 24.27 kB                                                                                                                                                                              18:38:54
../public/assets/style-478059d4.css   8.37 kB │ gzip: 2.62 kB                                                                                                                                                              18:38:54

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

I'm not seeing the gzip size in Vite 3:

vite v3.2.5 building for production...
✓ 7 modules transformed.
dist/assets/javascript.8dac5379.svg   0.97 KiB
dist/index.html                       0.44 KiB
dist/assets/index.5809de44.js         0.78 KiB / gzip: 0.44 KiB
dist/assets/sub.5e08839f.js           0.11 KiB / gzip: 0.12 KiB
dist/assets/index.d0964974.css        1.19 KiB / gzip: 0.62 KiB
dist/assets/sub.bb7f79bc.css          0.03 KiB / gzip: 0.05 KiB

Here's Vite 4:

vite v4.0.0 building for production...
✓ 7 modules transformed.
dist/index.html                      0.45 kB
dist/assets/javascript-8dac5379.svg  1.00 kB
dist/assets/sub-bb7f79bc.css         0.03 kB │ gzip: 0.05 kB
dist/assets/index-d0964974.css       1.22 kB │ gzip: 0.64 kB
dist/assets/sub-e69132ac.js          0.11 kB │ gzip: 0.12 kB
dist/assets/index-1d52d709.js        0.80 kB │ gzip: 0.45 kB

[meduzen]

You’re right, indeed. I’ve checked on Vite 2 as well.

Could it become a feature request? 👀

[mojoaxel]

The problem is in the reporter.ts plugin:

            compressedSize: isCSS
                      ? await getCompressedSize(chunk.source)
                      : null,

This was introduced with 186f669 by @ArnaudBarre in #10895

I have no idea why the compressed size is only shown for css files. But this is the problem!

[ArnaudBarre]

This was already the case before: https://github.com/vitejs/vite/pull/10895/files?w=1#diff-804926239ab7ce5dd12d3ba02244733917a7a54582b67c8212e130679aa00508L194

I don't know if gzip size makes a lot of sense for non text assets like images. But we can definitely add this for more content type than CSS

[meduzen]

I don't know if gzip size makes a lot of sense for non text assets like images.

For non-test assets, it probably doesn’t make sense as server-side on-the-fly compression (like gzip or brotli) isn’t effective. It’s only great for text like XML (HTML and SVG), CSS, JS and JSON.

[mojoaxel]

Instead if a simple isCss check we could do a regex for isCompressibleFile!?
I would feel honored if I could provide a merge request for this.

[ArnaudBarre]

Let's discuss the exact list with the team on the PR. Let's add html, svg, txt, json for an initial PR. Ping me on the PR