chore: replace esno with tsx, migrate release script and playground to TypeScript #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o TypeScript
* Replaces esno with tsx. Quoting esno: "From v0.15, esno is essentially an alias of tsx, with automated CJS/ESM mode and caching.".
* There are no benefits of caching here since we're only parsing one TS file at a time.
* Updated tsx version uses same esbuild version as Vite, reducing the number of dependencies.
* Migrates release script to TypeScript
* require() is dead!
* Minimal changes were required
* Migrates playground to TypeScript
* Set "type" to "module" - no more deprecated CJS Vite API warning!
* Removed "setupCounter(document.querySelector('#counter'))" leftover - neither #counter or setupCounter function were present.
bluwy
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks for cleaning this up! This looks great to me. I suppose at one point we also want to migrate the release script to something like: https://github.com/vitejs/vite-plugin-react/blob/40513235fb563041e757182f8d62ace8caa5a4e6/scripts/release.ts
|
That would be sweet! In the meantime, I hope you'll enjoy this at least for a short while :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
esnowithtsx. Quotingesno's own README:tsxversion (now primary, not secondary dev dependency) uses sameesbuildversion as Vite, reducing the number of dependencies.Migrates release script to TypeScript
require()is dead!Migrates playground to TypeScript
"type"to"module"- no more deprecated CJS Vite API warning!setupCounter(document.querySelector('#counter'))leftover - neither#counterorsetupCounterfunction were present.