Support custom domains

[gz65555]

This PR introduces the following features:

1. Custom domains
2. Custom cert directory
3. Custom name of certification

Can be easily set by:

// vite.config.js
import basicSsl from '@vitejs/plugin-basic-ssl'

export default {
  plugins: [
    basicSsl({name: "test", domains: ["*.custom.com"], certDir: "/Users/.../.devServer/cert"})
  ]
}

Some essential options can make our local development more comfortable. In Chrome, there will not be unfriendly security warnings.

[sarim]

It'd be nice to have this feature.
Building on top of it, providing rootCA to use for signing would be nice. (I have my own rootCA that is trusted in my devices) I can work on that after this is merged.

[bluwy]

The general idea sounds fine to me besides some comments below. We'd also need documentation for the new options though.

[gz65555]

@bluwy Thank you for reviewing, modifications are done.

[gz65555]

The options are quite simple, so I just update readme and add some comments on the options.

[patak-dev]

Maybe we should remove getCertificate from the public API? I don't know why we are exposing that, and we could directly pass the options as an object to it then.

[sarim]

I guess getCertificate function is exported for testing?

[patak-dev]

I guess getCertificate function is exported for testing?

It isn't used in the tests, no?

[sarim]

@patak-dev

vite-plugin-basic-ssl/test/test.spec.ts

Line 2 in 17ddf64

import { createCertificate } from '../src/certificate'

Update: Sorry, my bad. I mixed up the get and create.

[bluwy]

Looks great to me! Thanks for making the changes. My only question I guess is maybe we should rename certDir to cacheDir. Since certDir could mean the directory if you generated the certificates yourself and we respect that (which we don't). But not too concerned of the naming either since it's a low maintenance package.

About the getCertificate, perhaps we can remove that in the next major if we want to.

[patak-dev]

Let's release a minor then to have this feature and respect user defined settings too from the other PR.

@bluwy, would you expand on

My only question I guess is maybe we should rename certDir to cacheDir. Since certDir could mean the directory if you generated the certificates yourself and we respect that (which we don't).

I didn't get that, certDir sounds good here. We should rename cacheDir to certDir in getCertificate to me 🤔

[bluwy]

I didn't get that, certDir sounds good here. We should rename cacheDir to certDir in getCertificate to me 🤔

certDir technically is used more as a cache. And the other options didn't have the cert prefix, meaning they're implicitly cert related already. So I figured cacheDir was clearer.

[patak-dev]

Ah, I see. cacheDir may confuse some folks with the Vite cache dir. But I understand your point. Let's leave it for now then 👍🏼