Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 6, 2025

To unblock vitejs/vite#19996

@sapphi-red

This comment was marked as outdated.

@sapphi-red

This comment was marked as outdated.

@sapphi-red
Copy link
Member Author

@dominikg
Copy link
Collaborator

dominikg commented Jun 6, 2025

hmm, wouldn't that lead to vitest not using the vite version under test? if thats ok, should we find a way to not override local vitests vite?

@sapphi-red
Copy link
Member Author

It makes vitest to use Vite 6. Other packages will still use the local Vite.
If there's a way to not override local vitest's vite, that would be better. I didn't find a way to do it.

@sapphi-red
Copy link
Member Author

@sapphi-red sapphi-red marked this pull request as ready for review June 9, 2025 02:47
@sapphi-red sapphi-red changed the title chore: use Vite 6 for old Vitest feat: use Vite 6 for old Vitest Jun 9, 2025
@sapphi-red sapphi-red merged commit c922fa9 into main Jun 9, 2025
4 checks passed
@sapphi-red sapphi-red deleted the chore/override-use-vite-6-for-old-vitest branch June 9, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants