Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wxt suite #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add wxt suite #293

wants to merge 2 commits into from

Conversation

btea
Copy link

@btea btea commented Mar 7, 2024

@patak-dev
Copy link
Member

Thanks for the PR @btea! You'll also need to add wxt to the workflows. Check out the files modified when Remix was added: https://github.com/vitejs/vite-ecosystem-ci/pull/275/files

A question about the tests in wxt. I think these will be useful given that we don't have a similar project being tested right now. It would be interesting to know your take, and what kind of things you think will have more coverage because wxt is also part of vite-ecosystem-ci.

@btea
Copy link
Author

btea commented Mar 8, 2024

I only recently learned about wxt, and my understanding is limited. Maybe @aklinker1 can give more effective suggestions, what do you think? : )

@aklinker1
Copy link

Thanks for opening a PR for me @btea! I'll check this out soon

@dominikg
Copy link
Collaborator

@aklinker1 did you have a chance to look at this yet?

@aklinker1
Copy link

Nope, completely forgot about it. My priorities are elsewhere right now, but I'll leave this in my notifications to get to in when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants