fix: remove duplicate createRequire in optimizer#86
Merged
sapphi-red merged 1 commit intovitejs:rolldown-vitefrom Mar 10, 2025
Merged
Conversation
f794787 to
bc6ec1b
Compare
bc6ec1b to
235759a
Compare
sapphi-red
approved these changes
Mar 10, 2025
sapphi-red
pushed a commit
that referenced
this pull request
Mar 10, 2025
sapphi-red
pushed a commit
that referenced
this pull request
Mar 25, 2025
sapphi-red
pushed a commit
that referenced
this pull request
Mar 26, 2025
sapphi-red
pushed a commit
that referenced
this pull request
Mar 26, 2025
sapphi-red
pushed a commit
that referenced
this pull request
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is duplicate
createRequireinplayground/ssr-deps/node_modules/.vite/deps_ssr/chunk-B6b7aAQJ.jsdue to Rolldown's automatic polyfill and Vite's banner.Current Vite SSR is tolerating this code vitejs#19617, but this gets surfaced when oxc transform rejected this code #85.
I think the banner is redundant now, so just removing it seems fix it.