Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api-javascript): update transformIndexHtml types #603

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

Franqsanz
Copy link
Contributor

the documentation specified in the problem has been updated: #602

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for vite-docs-es ready!

Name Link
🔨 Latest commit 27323c6
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-es/deploys/65c544a2365df00008b903f7
😎 Deploy Preview https://deploy-preview-603--vite-docs-es.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mrcego mrcego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what happened, but the merge from main to patch-1 is dangerous in some manners. Please, do a full review about what you're committing.

Thanks.

docs/config/shared-options.md Outdated Show resolved Hide resolved
docs/config/shared-options.md Outdated Show resolved Hide resolved
docs/guide/build.md Outdated Show resolved Hide resolved
@Franqsanz
Copy link
Contributor Author

Hello, the truth is that I don't know what happened, it's some problem with the branch, I'm investigating.

@mrcego
Copy link
Member

mrcego commented Feb 8, 2024

Hello, the truth is that I don't know what happened, it's some problem with the branch, I'm investigating.

Let me know when you're sure these changes are ready.

Please, tag every fixed issue from commit.

Thanks in advance.

Copy link
Contributor Author

@Franqsanz Franqsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with these files, I have already deleted the ones "====" but the rest is fine as far as I can see.

@Franqsanz
Copy link
Contributor Author

It seems to be ok now, if there are still problems close the PR and I will open a new one.

docs/config/shared-options.md Outdated Show resolved Hide resolved
docs/config/shared-options.md Outdated Show resolved Hide resolved
docs/config/shared-options.md Outdated Show resolved Hide resolved
Repeated items have been deleted.
@Franqsanz
Copy link
Contributor Author

I have already removed the repeated items, this was my mistake, apologies for the loss of time. Thanks for your patience!

@mrcego mrcego merged commit 5e89cc4 into vitejs:main Feb 8, 2024
4 checks passed
@mrcego
Copy link
Member

mrcego commented Feb 8, 2024

I have already removed the repeated items, this was my mistake, apologies for the loss of time. Thanks for your patience!

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants