-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update workbox to 7.3.0 #781
Conversation
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/publish |
commit: |
Hello, the release of this PR (0.21.0) is marked with a breaking change. What exactly is breaking? So I can check if i have to adjust something in my project. I am not into workbox etc so i dont see it from just the dependency update. edit: ah i think i found it over in workbox as you jump from 6.5 to 7.3:
|
rollup version updated to fix XSS vulnerability |
Sorry if I'm making an extra effort, but I don't understand. Can you explain to me what the breaking change is and whether I have to pay attention to anything as a user of the plugin? |
Rollup removed in this PR and workbox changed the rollup version to fix the vulnerability (also Vite), if you're not using rollup in your app directly you can just update dependencies, it should work |
Description
This PR also includes:
rollup
from dev dependencies adding it to "pnpm.overrides"node:module
to fixDynamic require of "workbox-build"
errorWith this PR the plugin can still be used with Vite 3.
supersedes #759
Linked Issues
resolves #667
resolves #758
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publish
below.