Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum_lag_on_failover case when value set to 0 #808

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

garry-t
Copy link
Contributor

@garry-t garry-t commented Nov 14, 2024

  • fix case when set 0 for maximum_lag_on_failover

@vitabaks
Copy link
Owner

Could you attach an example of the error that we are correcting?

I don't think anyone will set 0 as this will turn off autofailover at the slightest replication lag

@garry-t
Copy link
Contributor Author

garry-t commented Nov 14, 2024

Could you attach an example of the error that we are correcting?

I don't think anyone will set 0 as this will turn off autofailover at the slightest replication lag

No errors, I just found that if I set 0, it ignores value and set default one. I dont know honestly if it reasonable to set 0 )), For me at least for now most important data integrity and if replication lag >0 I would prefer do not run failover.

@vitabaks
Copy link
Owner

In this case, just enable synchronous replication.

@vitabaks vitabaks merged commit aa9093d into vitabaks:master Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants