Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of AutoSplitLogWriter #15

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

PaperCube
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
neetbox ✅ Ready (Inspect) Visit Preview Mar 21, 2023 at 10:06AM (UTC)

@PaperCube PaperCube requested a review from visualDust March 21, 2023 10:08
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should put them in the same file as the Logger class does. Why not relocate these codes into neetbox/logging/config.py? That is reasonable because im gonna add some stream catchers and there might be some new options for building a logger. Since the code you add will be moved to somewhere else, re-sync your fork later if there are any further commits.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok. Once I have any further ideas on the design of the interface I will have them moved. If you have already formed any ideas you can just move them, or it's also fine to wait for my ideas.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great with your help ペーパーキューブ先生. I will do nothing on your code then.

@visualDust visualDust merged commit cd48af9 into master Mar 22, 2023
@PaperCube PaperCube deleted the feature-log-split branch March 23, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants