Skip to content

Commit

Permalink
docker workaround MSYS path conversion issue
Browse files Browse the repository at this point in the history
Without this on a Windows system with Git for Windows installed, I get:
```
docker: Error response from daemon: the working directory '\workspace\' is invalid, it needs to be an absolute path.
```

Apparently this is a known issue with Git for Windows: docker/for-win#1971 (comment)

It seems harmless to prepend a slash on any platform, to work around this.
  • Loading branch information
visr committed May 10, 2019
1 parent 9179499 commit 1872752
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/DockerRunner.jl
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function DockerRunner(workspace_root::String;
docker_cmd = `docker run --privileged `#--cap-add SYS_ADMIN`

if cwd != nothing
docker_cmd = `$docker_cmd -w $(abspath(cwd))`
docker_cmd = `$docker_cmd -w /$(abspath(cwd))`
end

# Add in read-only mappings and read-write workspaces
Expand Down

0 comments on commit 1872752

Please sign in to comment.