Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install more qt plugins. #19427

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

biagas
Copy link
Contributor

@biagas biagas commented Mar 27, 2024

Add 'tls', 'imageformats', 'iconengines'.
Streamlined logic related to plugins.

Resolves #19421.

Type of change

  • Bug fix
  • [ ] New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

Recompiled 3.4RC on WIndows and Linux, did an install and tried to import host profiles with success.

Checklist:

  • I have commented my code where applicable.~~
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Add 'tls', 'imageformats', 'iconengines'.
Streamlined logic related to plugins.
@biagas biagas requested review from cyrush and markcmiller86 March 27, 2024 21:10
@biagas
Copy link
Contributor Author

biagas commented Mar 27, 2024

@cyrush or @markcmiller86 Can you try this out on Mac make sure I didn't mess things up for that platform?

@biagas biagas merged commit 6b80cc0 into 3.4RC Apr 9, 2024
4 checks passed
@biagas biagas deleted the bugfix/biagas/install_more_qt_plugins branch April 9, 2024 23:09
biagas added a commit that referenced this pull request Apr 9, 2024
* Install more qt plugins.

Add 'tls', 'imageformats', 'iconengines'.
Streamlined logic related to plugins.

* Test for existence of some plugins before adding them to the list of plugins to install.
biagas added a commit that referenced this pull request Apr 10, 2024
* Install more qt plugins.

Add 'tls', 'imageformats', 'iconengines'.
Streamlined logic related to plugins.

* Test for existence of some plugins before adding them to the list of plugins to install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant