Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processOldVersions to CCPL to handle deprecated categoryName field #17820

Conversation

JustinPrivitera
Copy link
Member

@JustinPrivitera JustinPrivitera commented Jun 27, 2022

Description

Added in processOldVersions for CCPL to handle the deprecated categoryName.
Also added comment to ColorTableAttributes to correct any confusion.

Type of change

  • Bug fix~~
  • [ ] New feature
  • [ ] Documentation update
  • [ ] Other

How Has This Been Tested?

Added back in the line that sets categoryName to volumePlot.py, tested and ran on rztopaz.
Also ran w/ CLI and tried getting and setting categoryName to test the output messages.

Checklist:

  • I have followed the style guidelines of this project.~~
  • I have performed a self-review of my own code.~~
  • I have commented my code where applicable.~~
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • I have added debugging support to my changes.~~
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~
  • I have assigned reviewers (see VisIt's PR procedures for more information).~~

Copy link
Contributor

@biagas biagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this so quickly.

@JustinPrivitera JustinPrivitera merged commit 79a85d3 into 3.3RC Jun 27, 2022
@JustinPrivitera JustinPrivitera deleted the bugfix/JustinPrivitera/2022_06_27/add_processoldversions_to_ccpl branch June 27, 2022 21:11
@JustinPrivitera
Copy link
Member Author

merged w/ develop in #17823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants