Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json, npm and browserify support #70

Merged
merged 6 commits into from
Nov 25, 2015
Merged

package.json, npm and browserify support #70

merged 6 commits into from
Nov 25, 2015

Conversation

axelpale
Copy link
Collaborator

@axelpale axelpale commented May 4, 2015

This pull request solves issue/41, issue/42 and issue/71, the first two relating to missing package.json, missing npm entry and therefore missing browserify support. The issue/41 has many details about the issue and its solution. After the merge, move.js can be downloaded via npm and used with browserify but still continued to be used with component(1) just as before.

After merge, one more thing is required by you, precious collaborator: npm publish

This pull request includes

  • npm installation instructions in Readme.md
  • brand new package.json, rewritten from component.json
  • replacing require('emitter') by require('component-emitter') and similar as discussed in issue/41, providing compatibility for both component(1) and node/commonjs/browserify.
  • removing remotes from component.json because the public component must not contain any remotes. If remotes exists, running component install produces error no remote found for dependency ....
  • new builds of move.js and move.min.js, built with make move.js and make move.min.js. Apparently a few extra kilobytes were shaved off as well (28 kB -> 26 kB and 16 kB -> 14 kB).
  • Version bumb to 0.5.0, because otherwise some 0.4.0 would work with npm and some would not.

@axelpale axelpale mentioned this pull request May 9, 2015
@A
Copy link
Member

A commented Nov 25, 2015

+1 @tj @yields can I merge this pull request and publish it to the npm?

@tj
Copy link
Member

tj commented Nov 25, 2015

added both of you! LMK what the npm usernames are

axelpale added a commit that referenced this pull request Nov 25, 2015
package.json, npm and browserify support
@axelpale axelpale merged commit 1d0401c into visionmedia:master Nov 25, 2015
@axelpale
Copy link
Collaborator Author

@tj Thanks a lot! My npm username is xeli.

@axelpale
Copy link
Collaborator Author

@shuvalov-anton could you publish, I do not have time available until the weekend. Thanks!

@A
Copy link
Member

A commented Nov 25, 2015

@tj thank you :D shuvalov-anton

@tj
Copy link
Member

tj commented Nov 25, 2015

apparently I dont have access to the npm module either

@A
Copy link
Member

A commented Nov 28, 2015

@axelpale both move and movejs names are occupied. We should find the other one. Do you have ideas? Mb move.js?

@axelpale
Copy link
Collaborator Author

@shuvalov-anton I would prefer move-js because dash seems to be the convention in npm. For example, search packages with "js" and you get a long list of package names with a dash in them. Same thing happens if you search for "move".

@axelpale
Copy link
Collaborator Author

Btw, I removed false npm installation instructions from Readme.md that got there in this PR. After npm publish, the correct installation instructions should be added back, depending on the name, e.g:

...

With npm:

$ npm install move-js

...

@A
Copy link
Member

A commented Nov 30, 2015

@axelpale nice. move-js ok for me.

@axelpale
Copy link
Collaborator Author

@shuvalov-anton Now it is published \o/

@A
Copy link
Member

A commented Nov 30, 2015

Great! bicho-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants