Adding unittests for custom monitor commands#5
Merged
vishrutshah merged 2 commits intomonitor-clifrom Mar 7, 2017
Merged
Conversation
derekbekoe
approved these changes
Mar 6, 2017
derekbekoe
left a comment
derekbekoe
left a comment
There was a problem hiding this comment.
LGTM.
Instead of the assert False pattern, can you not assert of the boolean result itself?
e.g. assert bool(re.search(regex, filter_output))
derekbekoe
approved these changes
Mar 6, 2017
Owner
Author
|
Thanks for the review!! |
vishrutshah
added a commit
that referenced
this pull request
Mar 16, 2017
Adding list command for all azure monitor data plane Adding help docs for az monitor data plane commands Adding commands for management place of Azure monitor service Updating azure-monitor-cli to azure-mgmt-monitor and azure-monitor sdk Using nargs to input list of metric-names Implement filter for metrics list command Implement filter and select in activity-logs command Implement filter and select for tenant-activity-logs command Adding scaffold command in autoscale-settings (#4) Adding unittests for custom monitor commands (#5) Rename expanded params and resolve bugs * Fix expand parameters bug in util to support any parameters * Adding --filters into activity-logs & tenant-activity-logs * Adding --ids support into alert-rules & autoscale-settings' show and delete commands * ignoring filter for alert-rules and autoscale-settings list
vishrutshah
added a commit
that referenced
this pull request
Mar 22, 2017
… plane (Azure#2534) * Adding basic structure for monitor service * Adding list command for all azure monitor data plane * Adding help docs for az monitor data plane commands * Adding commands for management place of Azure monitor service * Updating azure-monitor-cli to azure-mgmt-monitor and azure-monitor sdk * Using nargs to input list of metric-names * Implement filter for metrics list command * Implement filter and select in activity-logs command * Implement filter and select for tenant-activity-logs command * Adding scaffold command in autoscale-settings (#4) * Adding unittests for custom monitor commands (#5) * Rename expanded params and resolve bugs * Fix expand parameters bug in util to support any parameters * Adding --filters into activity-logs & tenant-activity-logs * Adding --ids support into alert-rules & autoscale-settings' show and delete commands * ignoring filter for alert-rules and autoscale-settings list * Help docs for all monitor commands to review * rename activity-logs to activity-log * Removing tenant-activity-logs command * Removing event-categories commands as less useful * Update version to 0.0.1b1+dev * Renamed service-dignostic-settings to diagnostic-settings * update help for review * Update unittests for filters * Renaming parameter_abc into parameter * marking metric-names as required parameter for metrics list * Removing help.json from the review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding unittests for custom monitor commands.
@troydai @tjprescott @derekbekoe Please review the PR when you get a chance. Thanks!