Implement filter metrics list command#2
Conversation
There was a problem hiding this comment.
indeed. i missed it :)
There was a problem hiding this comment.
Is there a way for us to simplify this? Why would I have to type "duration'PT1M'"?
There was a problem hiding this comment.
I think if we can converts HH:mm:ss into ISO 8601. Let me look and see whether we have done it somewhere or not or how can we do that.
There was a problem hiding this comment.
Should clarify "The space separated list of metric names." Otherwise you will get people using comma separated values.
| filters.append('({})'.format(metrics_filter)) | ||
|
|
||
| if time_grain: | ||
| filters.append("timeGrain eq duration'{}'".format(time_grain)) |
There was a problem hiding this comment.
So this would read "timeGrain eq duration'duration'PT1M''"?
There was a problem hiding this comment.
Opps the help message is wrong. Help message should not be 'duration'PT1M'' only 'PT1M'
There was a problem hiding this comment.
haha..silly i can just avoid that.
* initial update * update * add the CLI for 2017-04-18 swagger file * cognitive service cli - inital version' * rollback debug code change * style refactoring update * update * change the term text to yellow highlighted * code comment fix - update #1 * fix code comments - update #2 * 1.fix flake 8 styling error 2. add the depedencies in setup, * fix an change in our service legal terms. * fix a help.py styling issue * update the setup.py * update description of setup.py
Before:
After:
Example 1:
Example 2:
XPlat CLI Reference: https://github.com/Azure/azure-xplat-cli/blob/dev/lib/commands/arm/insights/insights.metrics._js#L44
@troydai @tjprescott @derekbekoe Please review the PR when you get a chance. Thanks!