Switch to ESM module #2281
Merged
Switch to ESM module #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
approved these changes
Sep 12, 2023
| @@ -0,0 +1,5 @@ | |||
| import * as React from 'react'; | |||
|
|
|||
| export function createPortal(element, container) { | |||
There was a problem hiding this comment.
Hoping to learn what this does. Where is this used now? I only see the usage getting deleted.
There was a problem hiding this comment.
This file is used as an alias for react-dom during node tests, configured in ocularrc. Before we were hijacking the function with require('react-dom').createPortal = createPortalMock, but that no longer works in the ESM (import/export) world.
There was a problem hiding this comment.
Oh, ok got it. Could you comment that it's aliased in ocularrc?
Pessimistress
force-pushed
the
x/esm
branch
from
349327d
to
1011464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2272
Targeting v7.2