feat(core): Add View.clone() method #9588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
approved these changes
Apr 17, 2025
| t.is(clone.id, 'cloned-view', 'clone id is overridden'); | ||
| t.is(clone.props.zoom, 5, 'clone prop zoom is overridden'); | ||
| t.is(clone.props.latitude, view.props.latitude, 'other props are preserved'); | ||
| t.is(clone.props.longitude, view.props.longitude, 'other props are preserved'); |
Collaborator
There was a problem hiding this comment.
Can we also test that cloning a view should produce an identical view with matching matrices?
Collaborator
Author
There was a problem hiding this comment.
Can we also test that cloning a view should produce an identical view with matching matrices?
I considered it, but seemed to require a bit more work than I would like, I feel that adding the equal test should be pretty solid.
felixpalmer
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List