Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Fix off-by-one raster vertex shader error #9236

Merged
merged 2 commits into from
Nov 7, 2024
Merged

CARTO: Fix off-by-one raster vertex shader error #9236

merged 2 commits into from
Nov 7, 2024

Conversation

felixpalmer
Copy link
Collaborator

Background

The cells were being positioned incorrectly, see comparison with tile bounds:

raster-offset

Change List

  • Fix off by one error introduced by axis inversion
  • Fix import in test app

@coveralls
Copy link

Coverage Status

coverage: 91.616%. remained the same
when pulling 43770ed on felix/raster-shader-offset
into 920cf98 on master.

@felixpalmer felixpalmer merged commit 2de1bc5 into master Nov 7, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/raster-shader-offset branch November 7, 2024 16:34
felixpalmer added a commit that referenced this pull request Nov 8, 2024
@felixpalmer
CARTO: Fix off-by-one raster vertex shader error (#9236)
580f78c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @donmccurdy