CARTO: Add Layer exports to ease subclassing #9235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Nov 7, 2024
zbigg
reviewed
Nov 8, 2024
| data, | ||
| // TODO: Tileset2D should be generic over TileIndex type | ||
| TilesetClass: QuadbinTileset2D as any, | ||
| renderSubLayers, |
There was a problem hiding this comment.
I was thinking, that if we allow overriding TileLayer class, why not allowing overriding of RasterLayer too?
(that was something i wanted to do when experimenting with this class)
There was a problem hiding this comment.
I did consider that, but we have no precedent doing that elsewhere in TileLayer or subclasses. The design of TileLayer is to provide the renderSubLayers prop to allow the application to set (or override) the correct class. In this layer we hardcode it, preventing it from being set from the outside. Perhaps it would be better to move the definition of renderSubLayers to defaultProps like TileLayer does it?
zbigg
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A number of the internal types & layers were not exported, making it hard to customize/subclass
Change List
getSubLayerClassinCompositeLayerto allow_subLayerProps: {'layer': type}injections