Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU Aggregation (6/8): HexagonLayer #9098

Merged
merged 6 commits into from
Aug 23, 2024
Merged

GPU Aggregation (6/8): HexagonLayer #9098

merged 6 commits into from
Aug 23, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

There is a breaking change to the undocumented hexagonAggregator prop. I believe it was added for kepler @ibgreen

Change List

  • Move HexagonLayer to use new AggregationLayer and aggregator classes
  • Add gpuAggregation prop to HexagonLayer
  • Restore unit tests
  • Render tests

TODO

The CPU-only *ScaleType, *UpperPercentile, *LowerPercentile props are temporarily disabled, see #9096

ibgreen
ibgreen approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly a rubberstamp, the diff is huge.

modules/aggregation-layers/src/hexagon-layer/hexagon-cell-layer-vertex.glsl.ts Outdated Show resolved Hide resolved
modules/aggregation-layers/src/hexagon-layer/hexagon-cell-layer-vertex.glsl.ts Outdated Show resolved Hide resolved
modules/aggregation-layers/src/hexagon-layer/hexagon-cell-layer.ts Outdated Show resolved Hide resolved
modules/aggregation-layers/src/hexagon-layer/hexagon-layer.ts Show resolved Hide resolved
test/modules/aggregation-layers/hexbin.spec.ts Outdated Show resolved Hide resolved
@Pessimistress Pessimistress force-pushed the x/aggregation-5 branch 2 times, most recently from d6b7c48 to d477dce Compare August 21, 2024 23:56
@Pessimistress Pessimistress force-pushed the x/aggregation-6 branch 3 times, most recently from dc97ac7 to a96f8a4 Compare August 22, 2024 06:51
@Pessimistress Pessimistress changed the base branch from x/aggregation-5 to master August 22, 2024 22:21
@Pessimistress Pessimistress merged commit 427a95b into master Aug 23, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/aggregation-6 branch August 23, 2024 04:24
@coveralls
Copy link

Coverage Status

coverage: 88.902% (-0.2%) from 89.141%
when pulling af8b977 on x/aggregation-6
into fdbb88a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @ibgreen