Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers UBO #9008

Merged
merged 40 commits into from
Jul 8, 2024
Merged

Layers UBO #9008

merged 40 commits into from
Jul 8, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Jul 5, 2024

For #8997

Background

Change List

  • Make XXXUniformProps types required
  • Remove setUniforms calls
  • Port ArcLayer
  • Port ColumnLayer
  • Port GridCellLayer
  • Port IconLayer
  • Port LineLayer
  • Port PathLayer
  • Port PointCloudLayer
  • Port SolidPolygonLayer
  • Port MultiIconLayer
  • Port TextBackgroundLayer

@coveralls
Copy link

Coverage Status

coverage: 89.273% (+0.02%) from 89.253%
when pulling 212100e on felix/layers-ubo
into f8723cb on master.

@coveralls
Copy link

Coverage Status

coverage: 89.28% (+0.03%) from 89.253%
when pulling 3b0194a on felix/layers-ubo
into f8723cb on master.

@felixpalmer felixpalmer changed the title WIP: Layers UBO Layers UBO Jul 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.3% (+0.05%) from 89.253%
when pulling 2fe0fb5 on felix/layers-ubo
into f8723cb on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress!

@coveralls
Copy link

Coverage Status

coverage: 89.301% (+0.05%) from 89.253%
when pulling fb38a60 on felix/layers-ubo
into 7fa86b4 on master.

@donmccurdy donmccurdy merged commit c9cec91 into master Jul 8, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/layers-ubo branch July 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants