Extensions UBOs

[felixpalmer]

For #8997

Change List

• Port BrushingExtension
• Port ClipExtension
• Port CollisionFilterExtension
• Port FillStyleExtension
• Port PathStyleExtension
• Port TerrainExtension

[felixpalmer]

Any risk sharing the name between the modules?

[ibgreen]

Any risk sharing the name between the modules?

I am not quite sure what the context is but I would avoid using same name for two modules if that is the question.

[felixpalmer]

Luma assumes that the uniform block will be called ${moduleName}Uniforms - which for starters means we cannot use clip-fs.

It also means that if we cannot share the same uniformBlock across multiple modules. Perhaps we should add an optional ShaderModule.uniformBufferName in luma?

[ibgreen]

[Luma assumes] the uniform block will be called ${moduleName}Uniforms

Yes... was really a hack, not an intentional design. There are some restrictions to using the same name for both block names in shaders - so I added this logic to unblock things.

It also means that if we cannot share the same uniformBlock across multiple modules. Perhaps we should add an optional ShaderModule.uniformBufferName in luma?

Agreed, at some point we will want to revisit that. Perhaps a more explicit system would be better as you suggest.

which for starters means we cannot use clip-fs.

If the hyphen is the problem, we could easily add a hyphen-case to camelCase converter or just call the module clipfs?

[ibgreen]

LGTM.

[ibgreen]

Any risk sharing the name between the modules?

I am not quite sure what the context is but I would avoid using same name for two modules if that is the question.

[coveralls]

coverage: 89.253% (+0.02%) from 89.231%
when pulling cc2d5e3 on felix/extensions-ubos
into 2195b8b on master.