Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carto): Add missing 'client' parameter to query requests #8913

Merged
merged 8 commits into from
May 22, 2024

Conversation

donmccurdy
Copy link
Collaborator

Adds missing 'client' parameter to query requests from the @deck.gl/carto module.

Comments:

  • I've added client: DEFAULT_CLIENT to DEFAULT_PARAMETERS in common.ts. This is slightly redundant, as base-source.ts also defines it in SOURCE_DEFAULTS, but I see no harm in having both.
  • In basemap.ts we make some queries directly with fetch(), without these parameters. I'm not sure whether the parameters are expected, in that case.

@donmccurdy donmccurdy requested a review from felixpalmer May 21, 2024 22:10
@coveralls
Copy link

coveralls commented May 21, 2024

Coverage Status

coverage: 89.897% (+0.05%) from 89.846%
when pulling c8ff517 on donmccurdy/fix-sql-query-client-param
into 508649c on master.

@felixpalmer
Copy link
Collaborator

@donmccurdy I think it is better to pass the clientId via the same method we use in the data sources, to allow the application to customize it. I've updated the code & added a missing test for query()

@donmccurdy donmccurdy merged commit c31003b into master May 22, 2024
2 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/fix-sql-query-client-param branch May 22, 2024 21:35
donmccurdy added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants