Fix sin calculation using sin() #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivulet-zhang
force-pushed
the
icon-layer-sin-fix
branch
from
a0a6ead to
6f6f1e4
Compare
howtimeflies0
approved these changes
Aug 25, 2017
rivulet-zhang
force-pushed
the
icon-layer-sin-fix
branch
from
6f6f1e4 to
50896ac
Compare
rivulet-zhang
force-pushed
the
icon-layer-sin-fix
branch
from
50896ac to
a00788f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @shaojingli here #872:
use
sin()instead ofsqrt(...)to fix the issue of always generating positive values.