chore: Bump luma to 9.0.0-beta.6 #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gl into felix/bump-luma-9.0.0-beta.6
This reverts commit 7afd922.
ibgreen
approved these changes
Mar 4, 2024
modules/aggregation-layers/src/utils/gpu-grid-aggregation/gpu-grid-aggregator.ts
Show resolved
Hide resolved
modules/aggregation-layers/src/utils/gpu-grid-aggregation/gpu-grid-aggregator.ts
Show resolved
Hide resolved
| height: 1, | ||
| mipmaps: false, | ||
|
|
||
| // TODO fix getWebGLTextureParameters() in luma to avoid passing deprecated parameters |
There was a problem hiding this comment.
This will break very soon. Let's put up a luma PR on this ASAP.
| @@ -192,7 +192,7 @@ export default class SolidPolygonLayer<DataT = any, ExtraPropsT extends {} = {}> | |||
| // Provide a preproject function if the coordinates are in lnglat | |||
| preproject, | |||
| fp64: this.use64bitPositions(), | |||
| IndexType: !device || device.features.has('index-uint32-webgl1') ? Uint32Array : Uint16Array | |||
| IndexType: Uint32Array | |||
There was a problem hiding this comment.
FWIWI - the Buffer class has an indexType prop (just in case aligning is useful)
/** If props.usage includes Buffer.INDEX */
indexType?: 'uint16' | 'uint32';
| @@ -40,7 +40,7 @@ import * as testUtils from '@deck.gl/test-utils'; | |||
| test('Top-level imports', t0 => { | |||
| const hasEmptyExports = obj => { | |||
| for (const key in obj) { | |||
| if (!obj[key]) { | |||
| if (obj[key] === undefined) { | |||
There was a problem hiding this comment.
Are we getting null exports?
There was a problem hiding this comment.
Yes, test-utils exports device which is now null
| @@ -18,24 +18,24 @@ _global.HTMLVideoElement = dom.window.HTMLVideoElement; | |||
| _global.requestAnimationFrame = cb => setTimeout(cb, 0); | |||
| _global.cancelAnimationFrame = t => clearTimeout(t); | |||
|
|
|||
| import {gl, device} from '@deck.gl/test-utils'; | |||
| import {mockCanvasApi} from './utils/mock-canvas-api'; | |||
| // import {gl, device} from '@deck.gl/test-utils'; | |||
There was a problem hiding this comment.
This should be cleaned up in a follow-up, obviously.
…gl into felix/bump-luma-9.0.0-beta.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This bump introduces the removal of WebGL1 support, so unsurprisingly a number of things break.
Change List
WebGL2RenderingContexteverywheredevice.createTextureinstead ofWEBGLRenderBufferwireframerendering