Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tilejson in data prop for MVTLayer #8432

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Support Tilejson in data prop for MVTLayer #8432

merged 10 commits into from
Feb 15, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Jan 18, 2024 •
edited
Loading

For #8431

Background

TileLayer only allows the data prop to be URLTemplate, whereas the MVTLayer allows the direct passing of a TileJSON object (in the implementation, even if not in the types).

Change List

  • Manually force external types to be correct

@felixpalmer felixpalmer requested review from zbigg and ibgreen January 18, 2024 15:50
@felixpalmer felixpalmer merged commit f347293 into master Feb 15, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/tilelayer-prop-type branch February 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbigg zbigg zbigg approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixpalmer @zbigg