Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Only send baseUrl when request over max length #8429

Merged
merged 2 commits into from
Jan 18, 2024
Merged

CARTO: Only send baseUrl when request over max length #8429

merged 2 commits into from
Jan 18, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #8424

aaranadev
aaranadev approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@aaranadev aaranadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixpalmer felixpalmer merged commit 96d980b into master Jan 18, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/carto-baseUrl-fix branch January 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padawannn padawannn padawannn approved these changes

@aaranadev aaranadev aaranadev approved these changes

@donmccurdy donmccurdy Awaiting requested review from donmccurdy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @padawannn @aaranadev