Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v9 audit tile layer types #8387

Merged
merged 6 commits into from
Feb 8, 2024
Merged

v9 audit tile layer types #8387

merged 6 commits into from
Feb 8, 2024

Conversation

chrisgervang
Copy link
Collaborator

v9 port for #8291

Change List

  • Types internal state for TileLayer, MVTLayer, and SpatialIndexTileLayer
  • Initializes optional state to null if the layer resets it to null
  • Changes tile types from undefined to null where necessary

@chrisgervang
v9 audit tile layer types
dff5598 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
leave some type safety
15164ca 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
BigInt
a5e4fbf 
Signed-off-by: Chris Gervang <[email protected]>
ibgreen
ibgreen reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as the v8 version.

@chrisgervang chrisgervang mentioned this pull request Jan 13, 2024
Open
@chrisgervang chrisgervang merged commit cb431a8 into master Feb 8, 2024
2 checks passed
@chrisgervang chrisgervang deleted the chr/tile-layer-type-audit-v9 branch February 8, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgervang @ibgreen