Line layer elevations #241
Conversation
| float segmentIndex = positions.x; | ||
| vec2 mixed_temp[2]; | ||
|
|
||
| vec2_mix_fp64(projectedSourceCoord, projectedTargetCoord, segmentIndex, mixed_temp); | ||
|
|
||
| float mixedElevation = | ||
| mix(instanceElevations.x, instanceElevations.y, segmentIndex); | ||
|
|
There was a problem hiding this comment.
Thanks. We should have a glsl linter to catch that!
| }, | ||
| instanceElevations: { | ||
| size: 2, | ||
| update: this.calculateInstanceElevations |
There was a problem hiding this comment.
Can the type here be GL.UNSIGNED_BYTE or maybe the elevation can be negative?
There was a problem hiding this comment.
That would probably not be great since bytes only have 256 values. We want to support much better precision than that, and certainly higher elevations then 256 meters.
In this case we are using Float32s - since elevations are always in meters I assumed we don't need 64 bit values for these, like we do for long/lats.
I guess we might also want negative elevations although there are some open questions on how those should be rendered correctly.
There was a problem hiding this comment.
Ok that makes sense, thanks
No description provided.