fix(editable-layers): Fix import of PathMarkerLayer#432
Merged
ibgreen merged 1 commit intovisgl:masterfrom Nov 19, 2025
Merged
Conversation
ibgreen
approved these changes
Nov 19, 2025
Collaborator
ibgreen
left a comment
There was a problem hiding this comment.
Thanks for testing and fixing!
This may have been done when asking LLM to move the layers.
We may want to add some cross-import rules to AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
@deck.gl-community/editable-layersFixes, fegression from #333
This fix interesting issue with tsc jumping from "{moduleA}/dist/..." to "{moduleB}/src" when checking types.
Note, that currently distributed
node_modules/@deck.gl-community/editable-layers/dist/lib/layers/segments-layer.d.tsfor reads like this:That means, it imports not from "official types" of
@deck.gl-community/layerswhich live indist/..., but does "self-path-traversal-attack" and reaches to 'src' folder of this package.