Fix EditableGeoJsonLayerProps typing, expose SelectionLayerProps#219
Merged
charlieforward9 merged 4 commits intovisgl:masterfrom Nov 22, 2025
Merged
Fix EditableGeoJsonLayerProps typing, expose SelectionLayerProps#219charlieforward9 merged 4 commits intovisgl:masterfrom
charlieforward9 merged 4 commits intovisgl:masterfrom
Conversation
Collaborator
charlieforward9
left a comment
charlieforward9
left a comment
There was a problem hiding this comment.
Hey @timnyborg, thanks for making this contribution. Would you be able to update this branch on master so we can move forward with merging it in, I am doing a package-wide issue/PR triage and whatever help I can get with syncing these, the best. If not, please let me know so I can prioritze this among the other tasks.
timnyborg
force-pushed
the
props-typing
branch
from
7904cf8 to
84a73c1
Compare
Contributor
Author
|
@charlieforward9 This one's updated. The other two are on a fork belonging to an org I've since left, so I'll just open up some new PRs rebased on master |
charlieforward9
requested changes
Nov 22, 2025
timnyborg
force-pushed
the
props-typing
branch
from
9458dcc to
303d14a
Compare
charlieforward9
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls together a few fixes I had open on nebula.gl, that were approved but never merged or released:
uber/nebula.gl#873
uber/nebula.gl#858
uber/nebula.gl#777