fix(fc-pallet-pass): prevent reusing credentials#47
Merged
Conversation
…ss this parameter on both `Authenticator` and `UserAuthenticator` traits.
…efault`) and authentication (`inhereted_implication`) steps.
21 tasks
olanod
approved these changes
May 15, 2025
pandres95
added a commit
to virto-network/papi-signers
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some tests that are failing because it's possible to reuse some credentials that have been found out there to impersonate a pass account. This is completely inadmissible, as it poses a huge security risk, and must be fixed immediately. This PR fixes it.
Superseeds #40, as this solution uses the Transaction Extensions approach.
How the fix works
Challenger::generateandChallenger::validate_challengenow include a new parameter:extrinsic_context: impl AsRef<[u8]>. This parameter should be processed by the challenger.Pass::authenticateincludes an additional parameter:extrinsic_context: impl AsRef<[u8]>.inhereted_implicationfromTransactionExtensions::validatetoPass::authenticate.Since this value changes on each new transaction (because the nonce changes) we ensure each
What to change in external authenticators
External authenticators now must include the external challenge using this calculation1:
BLAKE2_256hasher;Footnotes
As defined by RFC 124 from the Polkadot Fellowship. ↩