feat(fs-gen, vmm): disable compression #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias-Boulay <[email protected]>
|
Example when using normal compression level: ...
[ 2.477661] IP-Config: Complete:
[ 2.479763] device=eth0, hwaddr=b6:93:57:01:b9:92, ipaddr=172.29.0.2, mask=255.255.0.0, gw=172.29.0.1
[ 2.486307] host=172.29.0.2, domain=, nis-domain=(none)
[ 2.490389] bootserver=255.255.255.255, rootserver=255.255.255.255, rootpath=
[ 2.490391] nameserver0=1.1.1.1
2024-05-30T16:14:07.505812Z ERROR vmm::grpc::client: Failed to connect to Agent service: transport error
2024-05-30T16:14:07.505883Z ERROR vmm::grpc::client: Retrying in 2s...
2024-05-30T16:14:09.507168Z ERROR vmm::grpc::client: Failed to connect to Agent service: transport error
2024-05-30T16:14:09.507210Z ERROR vmm::grpc::client: Retrying in 2s...
2024-05-30T16:14:11.509261Z ERROR vmm::grpc::client: Failed to connect to Agent service: transport error
2024-05-30T16:14:11.509302Z ERROR vmm::grpc::client: Retrying in 2s...
2024-05-30T16:14:13.511420Z ERROR vmm::grpc::client: Failed to connect to Agent service: transport error
2024-05-30T16:14:13.511474Z ERROR vmm::grpc::client: Retrying in 2s...
...
[ 19.803169] Run /init as init process
listening on http://0.0.0.0:50051/
2024-05-30T16:14:25.525841Z INFO vmm::grpc::server: Successfully connected to Agent service
...And we have almost no waiting time now, but we have very large images now (150MB to ~1GB). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in it?
This PR brings the ability to disable compression on the final image, via the
--no-compressionarg.Additionally, it enables the usage of this argument by vmm.
Why this PR?
Compression significantly increases startup times. This isn't desired behavior.