Skip to content

Fix Threat Detection tests for release .SDK v5 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viparek merged 3 commits into from
Apr 21, 2021
Merged

Fix Threat Detection tests for release .SDK v5 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b81fb88
FIX TESTS WITH SDK VERSION 5
ayeletshpigelman Apr 18, 2021
7143980
small fixes
ayeletshpigelman Apr 18, 2021
600a122
records of threat detection tests
ayeletshpigelman Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...ment/Microsoft.Azure.Management.Sql/tests/DatabaseVulnerabilityAssessmentScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ public async void TestCreateUpdateGetDatabaseVulnerabilityAssessments()
// Turn ON database threat detection as a prerequisite to use VA
DatabaseSecurityAlertPolicy updatedDatabasePolicy = new DatabaseSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
EmailAccountAdmins = SecurityAlertPolicyEmailAccountAdmins.Enabled
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};
sqlClient.DatabaseThreatDetectionPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);
sqlClient.DatabaseSecurityAlertPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);

// Verify Policy is empty to begin with
DatabaseVulnerabilityAssessment policyThatWasReceived = sqlClient.DatabaseVulnerabilityAssessments.Get(resourceGroup.Name, server.Name, dbName);
Expand Down Expand Up @@ -98,10 +98,10 @@ public async void TestCreateUpdateGetDeleteDatabaseVulnerabilityAssessmentBaseli
// Turn ON database threat detection as a prerequisite to use VA
DatabaseSecurityAlertPolicy updatedDatabasePolicy = new DatabaseSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
EmailAccountAdmins = SecurityAlertPolicyEmailAccountAdmins.Enabled
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};
sqlClient.DatabaseThreatDetectionPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);
sqlClient.DatabaseSecurityAlertPolicies .CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);

// Set policy
await SetPolicy(context, sqlClient, resourceGroup, server, dbName);
Expand Down Expand Up @@ -140,10 +140,10 @@ public async void TestExecuteGetListDatabaseVulnerabilityAssessmentScans()
// Turn ON database threat detection as a prerequisite to use VA
DatabaseSecurityAlertPolicy updatedDatabasePolicy = new DatabaseSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
EmailAccountAdmins = SecurityAlertPolicyEmailAccountAdmins.Enabled
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};
sqlClient.DatabaseThreatDetectionPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);
sqlClient.DatabaseSecurityAlertPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);

// Set policy
await SetPolicy(context, sqlClient, resourceGroup, server, dbName);
Expand Down Expand Up @@ -200,10 +200,10 @@ public async void TestExportDatabaseVulnerabilityAssessmentScans()
// Turn ON database threat detection as a prerequisite to use VA
DatabaseSecurityAlertPolicy updatedDatabasePolicy = new DatabaseSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
EmailAccountAdmins = SecurityAlertPolicyEmailAccountAdmins.Enabled
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};
sqlClient.DatabaseThreatDetectionPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);
sqlClient.DatabaseSecurityAlertPolicies.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, updatedDatabasePolicy);

// Set policy
await SetPolicy(context, sqlClient, resourceGroup, server, dbName);
Expand Down
2 changes: 1 addition & 1 deletion ...crosoft.Azure.Management.Sql/tests/ManagedDatabaseVulnerabilityAssessmentScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private async Task<DatabaseVulnerabilityAssessment> SetPolicy(SqlManagementTestC
// Modify the policy properties, send and receive and see it its still ok
ManagedServerSecurityAlertPolicy updatedManagedServerPolicy = new ManagedServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};

Expand Down
6 changes: 3 additions & 3 deletions ...ement/Microsoft.Azure.Management.Sql/tests/ManagedInstanceThreatDetectionScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void TestManagedInstanceThreatDetection()
// Modify the policy properties, send and receive and see it its still ok
ManagedServerSecurityAlertPolicy updatedManagedServerPolicy = new ManagedServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};

Expand All @@ -69,7 +69,7 @@ public void TestManagedInstanceThreatDetection()
// Modify the policy properties again, send and receive and see it its still ok
updatedManagedServerPolicy = new ManagedServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Disabled,
State = SecurityAlertsPolicyState.Disabled,
EmailAccountAdmins = true,
EmailAddresses = new List<string>() { "[email protected]", "[email protected]" },
DisabledAlerts = new List<string>() { "Sql_Injection" },
Expand Down Expand Up @@ -139,7 +139,7 @@ private ManagedServerSecurityAlertPolicy GetDefaultManagedInstanceSecurityAlertP
{
ManagedServerSecurityAlertPolicy properties = new ManagedServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Disabled,
State = SecurityAlertsPolicyState.Disabled,
EmailAccountAdmins = false,
DisabledAlerts = new List<string>() { string.Empty },
EmailAddresses = new List<string>() { string.Empty },
Expand Down
2 changes: 1 addition & 1 deletion ...crosoft.Azure.Management.Sql/tests/ManagedInstanceVulnerabilityAssessmentScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ private async Task<ManagedInstanceVulnerabilityAssessment> SetPolicy(SqlManageme
// Modify the policy properties, send and receive and see it its still ok
ManagedServerSecurityAlertPolicy updatedManagedServerPolicy = new ManagedServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};

Expand Down
2 changes: 1 addition & 1 deletion ...gement/Microsoft.Azure.Management.Sql/tests/ServerVulnerabilityAssessmentScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public async void TestCreateUpdateGetServerVulnerabilityAssessments()
// Turn ON Server ATP(threat detection) as a prerequisite to use VA
ServerSecurityAlertPolicy updatedServerPolicy = new ServerSecurityAlertPolicy
{
State = SecurityAlertPolicyState.Enabled,
State = SecurityAlertsPolicyState.Enabled,
EmailAccountAdmins = true
};

Expand Down
Loading