Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ScriptHost read from stdio #351

Merged
merged 4 commits into from
Jan 8, 2022
Merged

Let ScriptHost read from stdio #351

merged 4 commits into from
Jan 8, 2022

Conversation

vintagepc
Copy link
Owner

Description

Extend scripting to stdio so other programs can interface "live" with MK404.

Behaviour/ Breaking changes

None, only adds functionality.

Have you tested the changes?

Works locally.

Other

Scripting via stdio is only supported if no script file is loaded and --terminal is not enabled.

Linked issues:

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #351 (5db8852) into master (6770873) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   91.10%   91.40%   +0.29%     
==========================================
  Files         167      167              
  Lines        7733     7768      +35     
==========================================
+ Hits         7045     7100      +55     
+ Misses        688      668      -20     
Impacted Files Coverage Δ
parts/ScriptHost.h 92.30% <ø> (-0.55%) ⬇️
MK404.cpp 87.07% <100.00%> (+0.48%) ⬆️
parts/ScriptHost.cpp 65.14% <100.00%> (+8.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6770873...5db8852. Read the comment docs.

@vintagepc vintagepc merged commit f2a5895 into master Jan 8, 2022
@vintagepc vintagepc deleted the 350-stdio-scripting branch January 8, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] PTY scripting terminal
1 participant