Fix PINDA crash when probing nearby bed margins #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamp probing coordinates to be always inside the mesh. This is not correct when probing far away from the bed (PINDA shouldn't trigger at all), but for now this will do. Fixes vintagepc#313
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 89.08% 89.08%
=======================================
Files 140 140
Lines 6659 6661 +2
=======================================
+ Hits 5932 5934 +2
Misses 727 727
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clamp probing coordinates to be always inside the mesh.
This is not correct when probing far away from the bed (PINDA shouldn't trigger at all), but for now this will do.
Behaviour/ Breaking changes
None.
Have you tested the changes?
Tests included.
Linked issues:
Fixes #313