Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a flashair IP from the SD #290

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Return a flashair IP from the SD #290

merged 4 commits into from
Feb 3, 2021

Conversation

vintagepc
Copy link
Owner

@vintagepc vintagepc commented Feb 2, 2021

Description

Feature request to return an IP as if the simulated SD card is a FlashAir card.

Behaviour/ Breaking changes

Returns a data block with the IP if probed with the correct parameters to CMD48 (Extension register read)

Have you tested the changes?

Yes, works locally with official MK3 branch where support has been restored.
Also added test functionality to the test_SD card to read this block as part of the test.

Linked issues:

  • N/A - internal request.

@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #290 (f67f594) into master (ef089ab) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         140      140           
  Lines        6561     6575   +14     
=======================================
+ Hits         5863     5876   +13     
- Misses        698      699    +1     
Impacted Files Coverage Δ
parts/components/SDCard.h 100.00% <ø> (ø)
parts/components/SDCard.cpp 93.31% <92.85%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef089ab...f67f594. Read the comment docs.

@vintagepc vintagepc merged commit acc7202 into master Feb 3, 2021
@vintagepc vintagepc deleted the flashair-ip-address branch February 3, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants